Drop duplicate isPrimitive() in harness/testTypedArray.js#5036
Open
Drop duplicate isPrimitive() in harness/testTypedArray.js#5036
Conversation
ljharb
requested changes
Apr 20, 2026
Member
ljharb
left a comment
There was a problem hiding this comment.
this doesn't seem like a duplicate - where's the second function definition?
Member
|
Line 104 in 4a1e962 |
Member
|
ah ok, it's a global. makes sense |
ljharb
approved these changes
Apr 20, 2026
Contributor
|
Can we add |
Contributor
Author
|
Added it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's already defined in
harness/assert.js, included in every test.Some engines/runtimes e.g. deno complain about redeclarations in the same scope and abort execution.