Skip to content

[css-values] Use fetch 'conclude' instead of 'finalize'#7160

Merged
tabatkins merged 2 commits intow3c:mainfrom
noamr:fetch-controller
Mar 24, 2022
Merged

[css-values] Use fetch 'conclude' instead of 'finalize'#7160
tabatkins merged 2 commits intow3c:mainfrom
noamr:fetch-controller

Conversation

@noamr
Copy link
Copy Markdown
Collaborator

@noamr noamr commented Mar 20, 2022

[css-values-4] Fetch now exposes 'conclude' instead of 'finalize' which works with a fetch controller - this clarifies that resource timing entries are mapped to a fetch rather than to a response.

Comment thread css-values-4/Overview.bs
10. [=/Fetch=] |req|, with <var ignore>taskDestination</var> set to |global|, and <var ignore>processResponseConsumeBody</var>
set to the following steps given [=/response=] |res| and Null, failure or byte stream
|byteStream|:
10. Let |controller| be the result of [=/Fetch|fetching=] |req|, with <var ignore>taskDestination</var>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to make a change here, but just fyi, Bikeshed's conjugation support means you could just write [=/fetching=] and it'll link correctly to /fetch

@tabatkins tabatkins merged commit 10f6575 into w3c:main Mar 24, 2022
@tabatkins
Copy link
Copy Markdown
Member

Oh and also, for the future, please match the indentation whitespace of the spec you're editting; we use tabs in the CSSWG. If possible, also set your editor to strip line-final whitespace, as it'll cause diff churn the next time I touch the file otherwise.

@noamr
Copy link
Copy Markdown
Collaborator Author

noamr commented Mar 25, 2022

Oh and also, for the future, please match the indentation whitespace of the spec you're editting; we use tabs in the CSSWG. If possible, also set your editor to strip line-final whitespace, as it'll cause diff churn the next time I touch the file otherwise.

Gotcha, I'm working on several specs in parallel and sometimes the settings don't match :)

This was not supposed to be merged yet though - it depends on a fetch PR that wasn't merged yet. I see now that this is my bad since I forgot to put the "depends on" thing.

@tabatkins
Copy link
Copy Markdown
Member

Oh shoot, yeah, you didn't indicate in any way that it was a draft.

@noamr
Copy link
Copy Markdown
Collaborator Author

noamr commented Mar 26, 2022

Oh shoot, yeah, you didn't indicate in any way that it was a draft.

My bad, apologies again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants