[css-values-4][css-images-4][css-fonts-4] URL request modifiers#8222
Merged
[css-values-4][css-images-4][css-fonts-4] URL request modifiers#8222
Conversation
tabatkins
requested changes
Dec 14, 2022
Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>
Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>
Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>
Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>
Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>
Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>
Collaborator
Author
|
Thanks for the initial pass, @tabatkins... I was hoping bikeshed would run on the PR first but for some reason IPR check failed. |
noamr
changed the title
noamr
changed the title
Collaborator
Author
@tabatkins ping ? |
Collaborator
Author
Another ping @tabatkins ? |
tabatkins
approved these changes
Mar 7, 2023
Member
tabatkins
left a comment
tabatkins
left a comment
There was a problem hiding this comment.
Just two nits for linebreak formatting; each has a suggestion you can just accept. R+ after that!
Member
|
nm, i can accept my own suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a few URL modifiers to enable request parameters:
3 modifiers that correspond to
linkattributes:crossoriginreferrerpolicyintegrityThis enables CORS requests for CSS images, credentialed requests for fonts, and fine-tuning using integrity etc.
Example:
url("https://..." crossorigin(anonymous) integrity("shaX--something") referrerpolicy(same-origin))See #1603